Remove unnecessary Material imports from non-Material tests in flutter package by momshaddinury · Pull Request #185271 · flutter/flutter

momshaddinury · 2026-04-20T09:41:05Z

Several tests under packages/flutter/test/ were importing package:flutter/material.dart even though they only exercise APIs from package:flutter/widgets.dart (or lower layers like painting, animation, gestures). Pulling in Material unnecessarily increases cross-package coupling between these tests and the Material library and works against the cross-import hygiene enforced by dev/bots/check_tests_cross_imports.dart.

This PR:

Switches the import from package:flutter/material.dart to package:flutter/widgets.dart in tests that do not reference any Material symbols.
Where tests referenced Colors.* only, replaces those with the equivalent raw const Color(0x…) values.
Where tests wrapped widgets in MaterialApp purely as a Directionality/MediaQuery/localization host, swaps MaterialApp for TestWidgetsApp from widgets_app_tester.dart, and replaces materialTextSelectionControls with emptyTextSelectionControls.
Removes the corresponding entry from the check_tests_cross_imports.dart allowlist where applicable.

No production code is modified and no test semantics change — the tests exercise the same widget/painting/gesture/animation behavior, just without dragging in Material.

Files changed

Tests updated:

packages/flutter/test/gestures/force_press_test.dart
packages/flutter/test/gestures/transformed_scale_test.dart
packages/flutter/test/widgets/default_text_editing_shortcuts_test.dart
packages/flutter/test/widgets/semantics_owner_test.dart
packages/flutter/test/animation/animation_sheet_test.dart
packages/flutter/test/painting/star_border_test.dart
packages/flutter/test/painting/paint_image_test.dart

Allowlist updated:

dev/bots/check_tests_cross_imports.dart

Scope note — two files intentionally left out

Two test files originally staged in this cleanup were dropped after local test runs showed they aren't a clean Material → widgets swap. Details and a request for guidance are in a separate PR comment below:

packages/flutter/test/widgets/editable_text_scribe_test.dart — the handle-tap tests rely on CustomPaint widgets painted by materialTextSelectionControls; emptyTextSelectionControls paints nothing, so the handle finders return 0 widgets.
packages/flutter/test/widgets/editable_text_test.dart (Live Text test only) — swapping MaterialApp → TestWidgetsApp triggers A FocusManager was used after being disposed in the shared tearDown, cascading into five downstream a11y/semantics tests.

Both files remain on the check_tests_cross_imports.dart allowlist and can be picked up in follow-up PRs once we agree on the approach.

Related issues

Part of umbrella issue ☔ Framework unit tests shouldn't cross-import libraries #177028 (Framework unit tests shouldn't cross-import libraries).
Also addresses (Test cross-imports) No legacy Material imports in tests #177412 (No legacy Material imports in tests).

Context — why one PR

Per reviewer guidance from @navaronbracke on #185238 (comment), similar Material-import cleanups are being consolidated into a single PR that lands closer to the ~300–500-line "sweet spot" rather than as many tiny per-file PRs.

Superseded PRs (please close once this lands)

The following open PRs are subsumed by this one and can be closed if this PR is approved (see this comment):

Remove unused material.dart import from force_press_test.dart #185236 — Remove unused material.dart import from force_press_test.dart
Remove unnecessary Material import from default_text_editing_shortcuts_test #185241 — Remove unnecessary Material import from default_text_editing_shortcuts_test

Not superseded (corresponding files were dropped from this PR — see the scope note above):

Remove unnecessary Material import from editable_text_scribe_test #185238 — editable_text_scribe_test
Remove Material from Live Text test in editable_text_test #185242 — editable_text_test Live Text

Pre-launch Checklist

gemini-code-assist

Code Review

This pull request removes Material library dependencies from several tests by replacing MaterialApp with TestWidgetsApp, updating imports to widgets.dart, and substituting Material-specific constants like colors and selection controls with hardcoded values or generic alternatives. Feedback was provided regarding an inconsistent hex color value used for blue in editable_text_test.dart.

momshaddinury · 2026-04-20T09:43:02Z

Tagging @justinmc and @navaronbracke for review — this consolidates the Material-import cleanups per @navaronbracke's suggestion on #185238, and is part of the cross-import effort in #177028 / #177412.

victorsanni · 2026-04-23T00:47:29Z

                style: const TextStyle(fontSize: 10.0),
-                cursorColor: Colors.blue,
-                backgroundCursorColor: Colors.grey,
+                cursorColor: const Color(0xFF2196F3),


Nit: Since this is reused, maybe we can define a global const here? This will make it slightly easier to read.

Alright, makes sense. I'll address this.

Yeah I think that's what other people have done when migrating these tests off of Color.

momshaddinury · 2026-04-23T06:28:27Z

Heads-up @navaronbracke @justinmc @victorsanni — I dropped two files from this PR because neither is a clean Material → widgets swap:

editable_text_scribe_test.dart — the handle-tap tests at lines 186/231 use find.descendant(of: CompositedTransformFollower, matching: CustomPaint) to locate rendered selection handles, and emptyTextSelectionControls paints nothing.
editable_text_test.dart (Live Text test only) — swapping MaterialApp → TestWidgetsApp here triggers FocusManager was used after being disposed in the shared tearDown, cascading into five downstream a11y/semantics tests.

What's the preferred path forward — follow-up PRs with real fixes, stubs/workarounds, or leaving these in the allowlist? I can file tracking issues if that helps.

victorsanni

Hi @momshaddinury, can you fix the failing linux analyze CI check?

Where these tests previously used Colors.X, the cleanup PR that removed the Material import substituted the literal value of each constant (e.g. 0xFFF44336 for Colors.red). For tests that don't assert exact RGB values, pure-color hex codes (0xFFFF0000, etc.) are clearer about intent. - painting/star_border_test.dart: green 4CAF50 -> 00FF00 - widgets/default_text_editing_shortcuts_test.dart: blue 2196F3 -> 0000FF In default_text_editing_shortcuts_test.dart, also extract the cursor and background-cursor colors into top-level private consts (_cursorColor, _backgroundCursorColor) so the values are defined once and reused across all three EditableText sites. Also re-run `dart format` on the file, which collapses the two `testWidgets(...)` calls in the `Linux numpad shortcuts` group from the older multi-line style to the inline style. These are formatting changes only, no behavior changes. They surface because the format check validates files in the PR diff against the current dart_style version. Part of flutter#177028

navaronbracke

LGTM

@momshaddinury I had to review this with whitespace changes hidden, but that is because the formatting thing you explained in #185271 (comment) right?

momshaddinury · 2026-05-16T09:44:28Z

LGTM

@momshaddinury I had to review this with whitespace changes hidden, but that is because the formatting thing you explained in #185271 (comment) right?

Yes

momshaddinury · 2026-05-16T12:04:14Z

@navaronbracke @justinmc @victorsanni I am afraid there won't be anything to merge after a while. Already down to two files from 6. :3

justinmc

LGTM 👍

momshaddinury · 2026-05-17T15:37:18Z

@Piinks
@justinmc
@navaronbracke

It's passing all the tests. Good to merge?

momshaddinury · 2026-05-18T08:11:08Z

@Piinks let me know if anything else is needed before it gets merged. All checks have passed. Thanks.

victorsanni · 2026-05-18T21:48:45Z

editable_text_scribe_test.dart — the handle-tap tests at lines 186/231 use find.descendant(of: CompositedTransformFollower, matching: CustomPaint) to locate rendered selection handles, and emptyTextSelectionControls paints nothing.

I think here we can use testTextSelectionHandleControls here?

editable_text_test.dart (Live Text test only) — swapping MaterialApp → TestWidgetsApp here triggers FocusManager was used after being disposed in the shared tearDown, cascading into five downstream a11y/semantics tests.

This can be done in this PR as well?

Check this one: #185271 (comment)

Yes, and my reply was that both can be added to this PR.

gemini-code-assist Bot reviewed Apr 20, 2026

View reviewed changes

Comment thread packages/flutter/test/widgets/editable_text_test.dart Outdated

momshaddinury force-pushed the cleanup/test-remove-material-import branch from c93d48b to 0d04159 Compare April 20, 2026 09:51

justinmc added this to Test cross-imports Review Queue Apr 21, 2026

github-project-automation Bot moved this to Todo in Test cross-imports Review Queue Apr 21, 2026

justinmc requested review from justinmc and victorsanni April 21, 2026 22:20

momshaddinury force-pushed the cleanup/test-remove-material-import branch from 0d04159 to c435f7d Compare April 22, 2026 03:53

victorsanni previously approved these changes Apr 23, 2026

View reviewed changes

victorsanni added the CICD Run CI/CD label Apr 23, 2026

momshaddinury force-pushed the cleanup/test-remove-material-import branch from c435f7d to fc18fa4 Compare April 23, 2026 05:31

github-actions Bot removed the CICD Run CI/CD label Apr 23, 2026

navaronbracke reviewed Apr 23, 2026

View reviewed changes

Comment thread packages/flutter/test/gestures/force_press_test.dart

momshaddinury dismissed victorsanni’s stale review via 346f3ce April 23, 2026 06:21

momshaddinury force-pushed the cleanup/test-remove-material-import branch 2 times, most recently from 346f3ce to 2450cb8 Compare April 23, 2026 06:23

momshaddinury requested review from navaronbracke and victorsanni April 23, 2026 06:42

navaronbracke mentioned this pull request Apr 23, 2026

(Test cross-imports) The cross imports checker does not verify cross imports in flutter/xyz directories #185464

Closed

momshaddinury force-pushed the cleanup/test-remove-material-import branch from 2450cb8 to 072a369 Compare April 23, 2026 11:39

victorsanni added the CICD Run CI/CD label Apr 24, 2026

victorsanni approved these changes Apr 24, 2026

View reviewed changes

momshaddinury force-pushed the cleanup/test-remove-material-import branch from 06671b7 to de04920 Compare April 25, 2026 01:44

github-actions Bot removed the CICD Run CI/CD label Apr 25, 2026

navaronbracke previously approved these changes May 16, 2026

View reviewed changes

Merge branch 'master' into cleanup/test-remove-material-import

90433f6

justinmc approved these changes May 17, 2026

View reviewed changes

Merge branch 'master' into cleanup/test-remove-material-import

2f8e500

navaronbracke approved these changes May 18, 2026

View reviewed changes

victorsanni approved these changes May 21, 2026

View reviewed changes

Piinks mentioned this pull request May 29, 2026

Flutter Notable Commits - 2026 #181433

Open

Conversation

momshaddinury commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Files changed

Scope note — two files intentionally left out

Related issues

Context — why one PR

Superseded PRs (please close once this lands)

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

momshaddinury commented Apr 20, 2026

Uh oh!

Uh oh!

victorsanni Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

momshaddinury Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

justinmc Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

momshaddinury commented Apr 23, 2026

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

navaronbracke left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

momshaddinury commented May 16, 2026

Uh oh!

momshaddinury commented May 16, 2026

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

momshaddinury commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

momshaddinury commented May 18, 2026

Uh oh!

victorsanni commented May 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

momshaddinury commented Apr 20, 2026 •

edited

Loading

navaronbracke left a comment •

edited

Loading

momshaddinury commented May 17, 2026 •

edited

Loading