Skip to content

Remove unnecessary Material import from editable_text_scribe_test #185238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
momshaddinury wants to merge 1 commit into from
Closed

Remove unnecessary Material import from editable_text_scribe_test #185238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dev/bots/check_tests_cross_imports.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ class TestsCrossImportChecker {
'packages/flutter/test/widgets/editable_text_scribble_test.dart',
'packages/flutter/test/widgets/range_maintaining_scroll_physics_test.dart',
'packages/flutter/test/widgets/selectable_region_test.dart',
'packages/flutter/test/widgets/editable_text_scribe_test.dart',
'packages/flutter/test/widgets/semantics_debugger_test.dart',
'packages/flutter/test/widgets/page_route_builder_test.dart',
'packages/flutter/test/widgets/two_dimensional_scroll_view_test.dart',
Expand Down
10 changes: 6 additions & 4 deletions packages/flutter/test/widgets/editable_text_scribe_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@
import 'dart:ui' show PointerDeviceKind;

import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
Comment thread
navaronbracke marked this conversation as resolved.
import 'package:flutter/services.dart';
import 'package:flutter/widgets.dart';
import 'package:flutter_test/flutter_test.dart';

import 'widgets_app_tester.dart';

void main() {
final TestWidgetsFlutterBinding binding = TestWidgetsFlutterBinding.ensureInitialized();

Expand Down Expand Up @@ -58,17 +60,17 @@ void main() {
final provider = TextSelectionGestureDetectorBuilder(delegate: delegate);

await tester.pumpWidget(
MaterialApp(
TestWidgetsApp(
home: provider.buildGestureDetector(
behavior: HitTestBehavior.translucent,
child: EditableText(
key: editableTextKey,
controller: controller,
backgroundCursorColor: Colors.grey,
backgroundCursorColor: const Color(0xFF9E9E9E),
focusNode: focusNode,
style: textStyle,
cursorColor: cursorColor,
selectionControls: materialTextSelectionControls,
selectionControls: emptyTextSelectionControls,
showSelectionHandles: true,
),
),
Expand Down
Loading