Skip to content

Parse common SwiftPM errors and only fetch Swift packages when project is using SwiftPM #185218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vashworth wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Parse common SwiftPM errors and only fetch Swift packages when project is using SwiftPM #185218

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
fbf2831
Parse common SwiftPM errors
vashworth Apr 17, 2026
0f633dc
Merge remote-tracking branch 'upstream/main' into issue_184021
vashworth Apr 29, 2026
552cf55
++
vashworth Apr 29, 2026
abaed9b
++
vashworth Apr 30, 2026
54c62da
++
vashworth May 1, 2026
1164c3d
++
vashworth May 1, 2026
532a164
++
vashworth May 1, 2026
b3cb95e
++
vashworth May 1, 2026
6c5c75b
Merge remote-tracking branch 'upstream/main' into issue_184021
vashworth May 1, 2026
de045a6
++
vashworth May 1, 2026
8ea6be9
Move prefetch to XcodeBasedProject
vashworth May 5, 2026
906b817
var name
vashworth May 5, 2026
d49164b
fix tests
vashworth May 5, 2026
97a9ad4
fix tests
vashworth May 5, 2026
05e6127
fix test
vashworth May 6, 2026
037399e
Merge remote-tracking branch 'upstream/main' into issue_184021
vashworth May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
++
  • Loading branch information
@vashworth
vashworth committed May 1, 2026
commit 532a1643a76ffb440bd2e8355f58f5aa7384b893
9 changes: 0 additions & 9 deletions packages/flutter_tools/lib/src/ios/mac.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,13 +1122,8 @@ Future<bool> _handleIssues(
}

final XcodeBasedProject xcodeProject = platform.xcodeProject(project);
final List<Plugin> plugins = await xcodeProject.getPlugins();
final List<String> pluginNames = plugins.map((Plugin p) => p.name).toList();
final String? swiftPackageManagerMinPlatformMismatchMessage =
_swiftPackageManagerMinPlatformMismatchMessageFromStdout(result.stdout);
final String? swiftPackageManagerError =
SwiftPackageManager.parsePluginError(result.stdout, pluginNames: pluginNames) ??
SwiftPackageManager.parsePluginError(result.stderr, pluginNames: pluginNames);

if (requiresProvisioningProfile) {
logger.printError(noProvisioningProfileInstruction, emphasis: true);
Expand Down Expand Up @@ -1162,10 +1157,6 @@ Future<bool> _handleIssues(
} else if (swiftPackageManagerMinPlatformMismatchMessage != null) {
logger.printError(swiftPackageManagerMinPlatformMismatchMessage, emphasis: true);
issueDetected = true;
} else if (swiftPackageManagerError != null) {
print("HELLO 1");
logger.printError(swiftPackageManagerError, emphasis: true);
issueDetected = true;
} else if (duplicateModules.isNotEmpty) {
final bool usesCocoapods = xcodeProject.podfile.existsSync();
final bool usesSwiftPackageManager = xcodeProject.usesSwiftPackageManager;
Expand Down
1 change: 0 additions & 1 deletion packages/flutter_tools/lib/src/ios/xcodeproj.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,6 @@ class XcodeProjectInterpreter {
);

if (swiftPackageManagerError != null) {
print("HELLO 2");
_logger.printError(stderrString);
throwToolExit(swiftPackageManagerError);
}
Expand Down
Loading