Skip to content

Remove linux_android_emu_unstable android_engine_vulkan_tests#184787

Merged
auto-submit[bot] merged 4 commits intoflutter:masterfrom
gmackall:delete_unstable_vulkan_gold_tests
Apr 10, 2026
Merged

Remove linux_android_emu_unstable android_engine_vulkan_tests#184787
auto-submit[bot] merged 4 commits intoflutter:masterfrom
gmackall:delete_unstable_vulkan_gold_tests

Conversation

@gmackall
Copy link
Copy Markdown
Member

@gmackall gmackall commented Apr 8, 2026

This was pushing to the same golden files as the stable version. I suspect it is the source of flakiness of the vulkan platform view gold tests.

If we want to maintain parallel versions, we will in the future need to make the test harness ci-yaml-target-aware, in the way that it is for opengles vs vulkan.

@gmackall gmackall marked this pull request as ready for review April 8, 2026 21:18
@gmackall gmackall requested a review from a team April 8, 2026 21:18
@gmackall gmackall added the CICD Run CI/CD label Apr 8, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the linux_android_emu_unstable android_engine_vulkan_tests target from the .ci.yaml configuration. I have no feedback to provide.

@gmackall gmackall added CICD Run CI/CD and removed CICD Run CI/CD labels Apr 9, 2026
@github-actions github-actions bot removed the CICD Run CI/CD label Apr 9, 2026
@gmackall gmackall added the CICD Run CI/CD label Apr 9, 2026
@fluttergithubbot
Copy link
Copy Markdown
Contributor

An existing Git SHA, ea32df20f785a66a8c17c839627a4bed2a7e723f, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

@github-actions github-actions bot removed the CICD Run CI/CD label Apr 9, 2026
@gmackall gmackall added the CICD Run CI/CD label Apr 9, 2026
@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 9, 2026
@auto-submit auto-submit bot added this pull request to the merge queue Apr 9, 2026
Merged via the queue into flutter:master with commit 06ce217 Apr 10, 2026
169 of 170 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 10, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2026
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 10, 2026
flutter/flutter@81c87ea...bf18e39

2026-04-10 25263018+trizin@users.noreply.github.com [flutter_tools] Fix arm64e incorrectly matching arm64 in regex check (flutter/flutter#184057)
2026-04-10 jacksongardner@google.com Specify GitHub Repo in GH CLI calls for revert workflow. (flutter/flutter#184878)
2026-04-10 jacksongardner@google.com Don't use `git add -N` in the sync engine workflow. (flutter/flutter#184882)
2026-04-10 engine-flutter-autoroll@skia.org Roll Skia from af67d5555e35 to 25b01e5f4ea0 (14 revisions) (flutter/flutter#184865)
2026-04-10 737941+loic-sharma@users.noreply.github.com [Dot shorthands] Finish examples/api migration (flutter/flutter#183967)
2026-04-10 engine-flutter-autoroll@skia.org Roll Dart SDK from 98a143f8873e to e715805ddbd3 (1 revision) (flutter/flutter#184864)
2026-04-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Disable async mode with LLDB (#184768)" (flutter/flutter#184868)
2026-04-09 katelovett@google.com Skip freeze check in the merge queue (flutter/flutter#184854)
2026-04-09 116356835+AbdeMohlbi@users.noreply.github.com Remove unused variable in `ProcessTextPlugin.java` (flutter/flutter#184161)
2026-04-09 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pDXMXRIjEHTw7B0sk... to lZcRfPoCLnDttrf9P... (flutter/flutter#184842)
2026-04-09 engine-flutter-autoroll@skia.org Roll Dart SDK from bd6280c3e8e9 to 98a143f8873e (5 revisions) (flutter/flutter#184824)
2026-04-09 34871572+gmackall@users.noreply.github.com Remove `linux_android_emu_unstable android_engine_vulkan_tests` (flutter/flutter#184787)
2026-04-09 engine-flutter-autoroll@skia.org Roll Packages from 0e0a032 to 1aa892c (9 revisions) (flutter/flutter#184829)
2026-04-09 dacoharkes@google.com [record_use] Add experimental flag and test project (flutter/flutter#184719)
2026-04-09 15619084+vashworth@users.noreply.github.com Disable async mode with LLDB (flutter/flutter#184768)
2026-04-09 1063596+reidbaker@users.noreply.github.com Update link for rolling forward to aligned Dart hash (flutter/flutter#184780)
2026-04-09 engine-flutter-autoroll@skia.org Roll Skia from 4d0f5389e131 to af67d5555e35 (3 revisions) (flutter/flutter#184825)
2026-04-09 97480502+b-luk@users.noreply.github.com UberSDFContent refactoring and handle stroke miter limit for stroked rects (flutter/flutter#184603)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mbcorona pushed a commit to mbcorona/flutter that referenced this pull request Apr 15, 2026
…ter#184787)

This was pushing to the same golden files as the stable version. I
suspect it is the source of flakiness of the vulkan platform view gold
tests.

If we want to maintain parallel versions, we will in the future need to
make the test harness ci-yaml-target-aware, in the way that it is for
opengles vs vulkan.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants