Remove Material import from obscured_animated_image_test#184783
Closed
xfce0 wants to merge 1 commit intoflutter:masterfrom
Closed
Remove Material import from obscured_animated_image_test#184783xfce0 wants to merge 1 commit intoflutter:masterfrom
xfce0 wants to merge 1 commit intoflutter:masterfrom
Conversation
Part of flutter#177412. Replaces MaterialApp with TestWidgetsApp, removing the unnecessary dependency on package:flutter/material.dart. Also removes the file from the knownWidgetsCrossImports allowlist.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the test suite by removing 'packages/flutter/test/widgets/obscured_animated_image_test.dart' from the cross-import checker list. Additionally, it modifies 'packages/flutter/test/widgets/obscured_animated_image_test.dart' to replace 'MaterialApp' with 'TestWidgetsApp' and updates the imports accordingly. I have no feedback to provide as there are no review comments.
Contributor
Contributor
|
Yes it seems so: https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/obscured_animated_image_test.dart I'm going to close this PR then. @xfce0 Feel free to work on other tests, though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #177412.
Replaces
MaterialAppwithTestWidgetsApp, removing the unnecessary dependency onpackage:flutter/material.dartfrom a widgets-layer test. Also removes the file from theknownWidgetsCrossImportsallowlist indev/bots/check_tests_cross_imports.dart.Pre-launch Checklist
///).