ignore avoid_type_to_string lint rule#184765
Merged
srawlins merged 2 commits intoflutter:masterfrom Apr 21, 2026
Merged
Conversation
This change just ignores existing violations of avoid_type_to_string, which is enabled here, but hasn't been working. To get it working, for dart-lang/sdk#58377, we need to clean up these violations. An alternative to this change would be to ignore this rule in dev/bots/analysis_options.yaml
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds lint suppression for avoid_type_to_string in the toString methods of PreparePackageException and UnpublishException. The review feedback suggests hardcoding the class names instead of ignoring the lint to ensure the output remains reliable after code minification.
Contributor
|
@srawlins would you prefer to land this? Or should I send a PR to migrate these? |
Contributor
Author
|
I'd prefer to land this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change just ignores existing violations of avoid_type_to_string, which is enabled here, but hasn't been working. To get it working, for dart-lang/sdk#58377, we need to clean up these violations.
An alternative to this change would be to disable this rule in dev/bots/analysis_options.yaml