Refactor: remove material from absorb_ponter_test, container_test, lookup_boundary_test, page_view_test, router_test, semantics_clipping_test, semantics_merge_test, shadow_test, text_test by rkishan516 · Pull Request #183309 · flutter/flutter

rkishan516 · 2026-03-06T15:19:51Z

This PR removes Material imports from absorb_ponter_test, container_test,
lookup_boundary_test, page_view_test, router_test, semantics_clipping_test, semantics_merge_test, shadow_test, text_test.

part of: #177415

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

gemini-code-assist

Code Review

This pull request is a refactoring effort to remove dependencies on the material library from several widget tests. The changes primarily involve replacing MaterialApp with TestWidgetsApp, substituting Material-specific widgets and constants with equivalents from the widgets library or local test helpers, and updating the check_tests_cross_imports.dart script accordingly. The refactoring is consistent across all modified files and appears to be well-executed, successfully decoupling these tests from the material library.

_{Note: Security Review is unavailable for this PR.}

flutter-dashboard · 2026-03-06T16:08:13Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #183309 at sha ae2659c

victorsanni

I left some comments, open to hearing your thoughts.

flutter-dashboard · 2026-03-07T10:41:14Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #183309 at sha 86e0a78

flutter-dashboard · 2026-03-07T18:23:14Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #183309 at sha 8b91427

flutter-dashboard · 2026-03-08T02:40:15Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #183309 at sha fa6ba10

flutter-dashboard · 2026-03-10T18:18:20Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #183309 at sha 0c92c97

flutter-dashboard · 2026-03-12T00:16:32Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #183309 at sha f55d320

auto-submit · 2026-04-02T02:24:10Z

autosubmit label was removed for flutter/flutter/183309, because - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter-dashboard · 2026-04-02T03:42:04Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #183309 at sha 36d2ad9

rkishan516 · 2026-04-02T04:05:54Z

Now the background color change is just because scaffold used to give different background color than exact white that we are using.

victorsanni

Now the background color change is just because scaffold used to give different background color than exact white that we are using.

Can we use the scaffold color in the tests? So that we don't have to re-triage the goldens.

…okup_boundary_test, page_view_test, router_test, semantics_clipping_test, semantics_merge_test, shadow_test, text_test

…TestWidgetsApp

…r_test, lookup_boundary_test, page_view_test, router_test, semantics_clipping_test, semantics_merge_test, shadow_test, text_test (flutter/flutter#183309)

flutter/flutter@a0924c7...05e0ae0 2026-04-08 meylis@divine.video Fix Android engine flags defaulting to true for malformed values (flutter/flutter#184631) 2026-04-08 katelovett@google.com Try one more again (flutter/flutter#184767) 2026-04-08 goderbauer@google.com Remove custom `analysis_options.yaml` from `imitation_game_flutter` (flutter/flutter#184717) 2026-04-08 victorsanniay@gmail.com Add more error handling to unawaited callsites (flutter/flutter#184526) 2026-04-08 34465683+rkishan516@users.noreply.github.com Refactor: remove material from absorb_ponter_test, container_test, lookup_boundary_test, page_view_test, router_test, semantics_clipping_test, semantics_merge_test, shadow_test, text_test (flutter/flutter#183309) 2026-04-08 73785960+xfce0@users.noreply.github.com Remove editable_text_utils cross-imports from material and cupertino … (flutter/flutter#184519) 2026-04-08 robert.ancell@canonical.com Replace hard coded max path length with system defined one. (flutter/flutter#184697) 2026-04-08 jesswon@google.com [Re-land] Add Support For Built-in Kotlin (flutter/flutter#184745) 2026-04-08 15619084+vashworth@users.noreply.github.com Manually stop and continue LLDB breakpoints on Xcode 26.4+ (flutter/flutter#184690) 2026-04-08 katelovett@google.com Code freeze workflow (flutter/flutter#184246) 2026-04-08 737941+loic-sharma@users.noreply.github.com [Dot shorthands] Migrate examples/api/lib/widgets (flutter/flutter#183965) 2026-04-08 59215665+davidhicks980@users.noreply.github.com [cupertino.dart] Implement CupertinoMenuAnchor and CupertinoMenuItem using RawMenuAnchor (flutter/flutter#182036) 2026-04-08 87018443+mayanksharma9@users.noreply.github.com [Semantics] clarify Android header docs (flutter/flutter#183573) 2026-04-08 dacoharkes@google.com [ci] mac build_test bringup false (flutter/flutter#184738) 2026-04-08 34871572+gmackall@users.noreply.github.com Reland "Apply rect clipping to surface views" (flutter/flutter#184732) 2026-04-08 bkonyi@google.com Remove bringup label for resharded Windows tool_integration_tests shards (flutter/flutter#184721) 2026-04-08 namangoyaldev@gmail.com Tool: Add search and filtering to widget preview scaffold (flutter/flutter#184023) 2026-04-08 36861262+QuncCccccc@users.noreply.github.com Update localization from translation console (flutter/flutter#184742) 2026-04-07 rmolivares@renzo-olivares.dev Revert "Add Support For Built-in Kotlin (#184227)" (flutter/flutter#184739) 2026-04-07 34871572+gmackall@users.noreply.github.com Collect HCPP adoption analytics for flutter run/build apk/build appbundle (flutter/flutter#184225) 2026-04-07 jacksongardner@google.com Add a github workflow for reverting PRs. (flutter/flutter#184593) 2026-04-07 jesswon@google.com Add Support For Built-in Kotlin (flutter/flutter#184227) 2026-04-07 34871572+gmackall@users.noreply.github.com Revert "Apply rect clipping to surface views (#184471)" (flutter/flutter#184728) 2026-04-07 jesswon@google.com [Fix-forward] Added Compose plugin to Add-to-app Integration Test (flutter/flutter#184681) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…okup_boundary_test, page_view_test, router_test, semantics_clipping_test, semantics_merge_test, shadow_test, text_test (flutter#183309) This PR removes Material imports from absorb_ponter_test, container_test, lookup_boundary_test, page_view_test, router_test, semantics_clipping_test, semantics_merge_test, shadow_test, text_test. part of: flutter#177415 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

rkishan516 requested review from justinmc and victorsanni March 6, 2026 15:19

rkishan516 added this to Test cross-imports Review Queue Mar 6, 2026

github-project-automation Bot moved this to Todo in Test cross-imports Review Queue Mar 6, 2026

rkishan516 moved this from Todo to In Progress in Test cross-imports Review Queue Mar 6, 2026

rkishan516 mentioned this pull request Mar 6, 2026

(Test cross-imports) Don't import Material in tests for convenience #177415

Open

gemini-code-assist Bot reviewed Mar 6, 2026

View reviewed changes

flutter-dashboard Bot added the will affect goldens Changes to golden files label Mar 6, 2026

victorsanni reviewed Mar 6, 2026

View reviewed changes

rkishan516 force-pushed the simple-cross-imports-6 branch from ae2659c to 86e0a78 Compare March 7, 2026 09:53

rkishan516 force-pushed the simple-cross-imports-6 branch 3 times, most recently from 5017662 to 8b91427 Compare March 7, 2026 17:28

rkishan516 force-pushed the simple-cross-imports-6 branch from 8b91427 to fa6ba10 Compare March 8, 2026 01:41

rkishan516 force-pushed the simple-cross-imports-6 branch from fa6ba10 to 0c92c97 Compare March 10, 2026 17:27

rkishan516 force-pushed the simple-cross-imports-6 branch 2 times, most recently from 062d2c0 to f55d320 Compare March 11, 2026 23:25

victorsanni self-requested a review March 11, 2026 23:27

victorsanni previously approved these changes Mar 13, 2026

View reviewed changes

Comment thread packages/flutter/test/widgets/test_page_tester.dart

rkishan516 dismissed victorsanni’s stale review via 96f2d2a March 14, 2026 02:40

rkishan516 force-pushed the simple-cross-imports-6 branch from 66c515e to 36d2ad9 Compare April 2, 2026 02:54

github-actions Bot removed the CICD Run CI/CD label Apr 2, 2026

rkishan516 added the CICD Run CI/CD label Apr 2, 2026

victorsanni previously approved these changes Apr 3, 2026

View reviewed changes

rkishan516 added 5 commits April 4, 2026 20:33

refactor: remove material from absorb_ponter_test, container_test, lo…

1a9a5fb

…okup_boundary_test, page_view_test, router_test, semantics_clipping_test, semantics_merge_test, shadow_test, text_test

refactor: changes based on feedback

eb30ffc

fix: golden names for TestDecoration

1241db7

update color for page view background color

d6a7d9f

test: update page view tests to match goldens by adding textStyle to …

5b9ca83

…TestWidgetsApp

rkishan516 dismissed victorsanni’s stale review via 5b9ca83 April 4, 2026 15:03

rkishan516 force-pushed the simple-cross-imports-6 branch from 36d2ad9 to 5b9ca83 Compare April 4, 2026 15:03

github-actions Bot removed the CICD Run CI/CD label Apr 4, 2026

rkishan516 added the CICD Run CI/CD label Apr 4, 2026

victorsanni approved these changes Apr 7, 2026

View reviewed changes

rkishan516 added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2026

auto-submit Bot added this pull request to the merge queue Apr 8, 2026

Merged via the queue into flutter:master with commit 451607a Apr 8, 2026
150 of 151 checks passed

github-project-automation Bot moved this from In Progress to Done in Test cross-imports Review Queue Apr 8, 2026

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2026

engine-flutter-autoroll mentioned this pull request Apr 8, 2026

Roll Flutter from a0924c76b0fd to 4621d0b6a7ed (22 revisions) flutter/packages#11468

Closed

rkishan516 deleted the simple-cross-imports-6 branch April 8, 2026 15:49

engine-flutter-autoroll mentioned this pull request Apr 8, 2026

Roll Flutter from a0924c76b0fd to 05e0ae02600d (24 revisions) flutter/packages#11470

Merged

Conversation

rkishan516 commented Mar 6, 2026

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

flutter-dashboard Bot commented Mar 6, 2026

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

flutter-dashboard Bot commented Mar 7, 2026

Uh oh!

flutter-dashboard Bot commented Mar 7, 2026

Uh oh!

flutter-dashboard Bot commented Mar 8, 2026

Uh oh!

flutter-dashboard Bot commented Mar 10, 2026

Uh oh!

flutter-dashboard Bot commented Mar 12, 2026

Uh oh!

Uh oh!

auto-submit Bot commented Apr 2, 2026

Uh oh!

flutter-dashboard Bot commented Apr 2, 2026

Uh oh!

rkishan516 commented Apr 2, 2026

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants