Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/devicelab/bin/tasks/hello_world_impeller.dart
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Future<TaskResult> run() async {
isUsingValidationLayers = true;
}
// "ImpellerValidationBreak" comes from the engine:
// https://github.com/flutter/engine/blob/4160ebacdae2081d6f3160432f5f0dd87dbebec1/impeller/base/validation.cc#L40
// https://github.com/flutter/flutter/blob/91b2d41a66d1c540233b819525553afc0fa1f58d/engine/src/flutter/impeller/base/validation.cc#L54
if (data.contains('ImpellerValidationBreak')) {
hasValidationErrors = true;
}
Expand Down
2 changes: 1 addition & 1 deletion docs/engine/impeller/Flutter-GPU.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ dependencies:

- [Project dashboard](https://github.com/orgs/flutter/projects/134/views/1)
- [Original design doc](https://flutter.dev/go/impeller-dart) (now outdated!)
- [flutter_gpu package source](https://github.com/flutter/engine/tree/main/lib/gpu)
- [flutter_gpu package source](https://github.com/flutter/flutter/tree/main/engine/src/flutter/lib/gpu)

## Dart FFI

Expand Down
2 changes: 1 addition & 1 deletion docs/platforms/android/Texture-Layer-Hybrid-Composition.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ It was introduced in Flutter 3.0 to combine the best aspects of Virtual Display

# Approach

TLHC uses a [custom `FrameLayout`](https://github.com/flutter/engine/blob/7025645c52bfaeb1cc67be5ca842b65772c89c8e/shell/platform/android/io/flutter/plugin/platform/PlatformViewWrapper.java#L35-L46), which is placed in the native view hierarchy as normal, but [redirects drawing](https://github.com/flutter/engine/blob/7025645c52bfaeb1cc67be5ca842b65772c89c8e/shell/platform/android/io/flutter/plugin/platform/PlatformViewWrapper.java#L299-L309) to a canvas that backs a Flutter [`Texture`](https://api.flutter.dev/flutter/widgets/Texture-class.html) in order to compose with the rest of the Flutter UI as normal (without the layering and threading complexities of Hybrid Composition).
TLHC uses a [custom `FrameLayout`](https://github.com/flutter/flutter/blob/91b2d41a66d1c540233b819525553afc0fa1f58d/engine/src/flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewWrapper.java#L29-L39), which is placed in the native view hierarchy as normal, but [redirects drawing](https://github.com/flutter/flutter/blob/91b2d41a66d1c540233b819525553afc0fa1f58d/engine/src/flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewWrapper.java#L178-L187) to a canvas that backs a Flutter [`Texture`](https://api.flutter.dev/flutter/widgets/Texture-class.html) in order to compose with the rest of the Flutter UI as normal (without the layering and threading complexities of Hybrid Composition).

# Limitations

Expand Down
2 changes: 1 addition & 1 deletion engine/src/flutter/tools/gradle/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Gradle version that you downloaded and verified.
1. Authenticate with CIPD by running `cipd auth-login`.
2. Run `cipd create -in gradle-7.5.1 -install-mode copy -tag version:7.5.1 -name flutter/gradle` to
upload the new Gradle version to CIPD.
3. Update the `engine/src/flutter/DEPS` Gradle entry (which should look something like [this](https://github.com/flutter/engine/blob/4caaab9f2502481b606b930abeea4a361022fa16/DEPS#L732-L743))
3. Update the `engine/src/flutter/DEPS` Gradle entry (which should look something like [this](https://github.com/flutter/flutter/blob/91b2d41a66d1c540233b819525553afc0fa1f58d/DEPS#L573))
Comment thread
AbdeMohlbi marked this conversation as resolved.
Outdated
to contain the tag from the command above (version:7.5.1).
4. Run `gclient sync` to verify that the dependency can be fetched.

Expand Down