Skip to content

some whitespace cleanup#14443

Merged
a14n merged 1 commit into
flutter:masterfrom
a14n:whitespace-cleanup
Feb 2, 2018
Merged

some whitespace cleanup#14443
a14n merged 1 commit into
flutter:masterfrom
a14n:whitespace-cleanup

Conversation

@a14n
Copy link
Copy Markdown
Contributor

@a14n a14n commented Feb 2, 2018

No description provided.

@Hixie
Copy link
Copy Markdown
Contributor

Hixie commented Feb 2, 2018

LGTM

One thing I sometimes see that you may be interested in looking at is the inconsistency between while( and while ( (and same with for, catch, if, etc). For keywords, we generally prefer a space before the ( to distinguish it from a method call.

@a14n a14n merged commit c02b6a8 into flutter:master Feb 2, 2018
@a14n a14n deleted the whitespace-cleanup branch February 2, 2018 22:27
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants