Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[windows] Use FML_DCHECK in place of C assert#38826

Merged
cbracken merged 1 commit into
flutter:mainfrom
cbracken:fml-check-not-assert
Jan 13, 2023
Merged

[windows] Use FML_DCHECK in place of C assert#38826
cbracken merged 1 commit into
flutter:mainfrom
cbracken:fml-check-not-assert

Conversation

@cbracken
Copy link
Copy Markdown
Member

@cbracken cbracken commented Jan 13, 2023

Now that the embedders depend on FML, migrate assertions to FML_DCHECK, which allows for an explanatory log message to be emitted along with the assertion.

The log strings will slightly increase the size of debug binaries, but will not affect release binaries.

No tests since no semantic changes are made.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants