Skip to content

Rebuild plugin_codelab#58

Merged
domesticmouse merged 8 commits into
flutter:masterfrom
domesticmouse:undo-mistake
Jan 26, 2021
Merged

Rebuild plugin_codelab#58
domesticmouse merged 8 commits into
flutter:masterfrom
domesticmouse:undo-mistake

Conversation

@domesticmouse
Copy link
Copy Markdown
Contributor

No description provided.

@domesticmouse
Copy link
Copy Markdown
Contributor Author

I'm unsure why plugin_codelab is failing only on the ubuntu-latest stable CI check, and not macOS nor Windows stable. I'm hoping #57 fixes it.

@domesticmouse
Copy link
Copy Markdown
Contributor Author

Related issue: flutter/flutter#74207

@domesticmouse
Copy link
Copy Markdown
Contributor Author

TBR @johnpryan

@domesticmouse domesticmouse merged commit 2ed9028 into flutter:master Jan 26, 2021
@domesticmouse domesticmouse deleted the undo-mistake branch January 26, 2021 22:02
Copy link
Copy Markdown
Contributor

@johnpryan johnpryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

<root url="file:///home/brett/flutter/bin/cache/dart-sdk/lib/isolate" />
<root url="file:///home/brett/flutter/bin/cache/dart-sdk/lib/math" />
<root url="file:///home/brett/flutter/bin/cache/dart-sdk/lib/mirrors" />
<root url="file:///home/brett/flutter/bin/cache/dart-sdk/lib/typed_data" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this directory?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing I should .gitignore the .idea directory?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL at #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants