firebase-get-to-know-flutter: separate main.dart into different files#1206
Conversation
|
I realized that the files in this codelab don't have a copyright header, which is present in other codelabs. Let me know if the new files need that as well. |
|
Yes, @miquelbeltran - Please add license headers |
I have a WIP PR that is going to be adding license headers per https://github.com/flutter/codelabs/blob/main/CONTRIBUTING.md#file-headers I've yet to make it as far as this codelab tho =) |
|
I think the codelab.md might be out of sync with what is published on the site. I can land an update to that momentarily. |
|
Added license headers. I skipped the |
domesticmouse
left a comment
There was a problem hiding this comment.
Free to land when tests pass
As preparation for migrating the codelab to go_router (and Material 3 later on)
Work is mostly copy/paste and re-formatting, changes are organized in commit per step for easier review.
Final code organization is as follows:
The only doubt I had was if the
Attendingenumshould be a separated file or not, since it was only used by theApplicationState, I left it insideapp_state.dartI did not update the
codelab_rebuild.yamlas I am still not sure how to do that, but I can give it a try if you let me know how.We would need to update the codelab document as well. I can do that after go_router has been adopted, or I can do that now before migrating to go_router. Please let me know what you prefer.
cc. @domesticmouse @nohe427 @redbrogdon
Pre-launch Checklist
///). <-- Codelab needs updateIf you need help, consider asking for advice on the #hackers-devrel channel on Discord.