Repository navigation
Fix UserDict doctest for Python 3.12 and later - #74
Open
carlitogwapito wants to merge 1 commit into
Open
carlitogwapito wants to merge 1 commit into
carlitogwapito wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #73.
UserDict.get()changed in Python 3.12, so the example's expected result now depends on the Python version. This adds a short explanation and checks the matching result in the doctest. All imports, classes and methods outside the module docstring are unchanged.Checked the module's 22 doctest examples with the standard-library
doctestrunner on Python 3.12.0 and 3.14.4: all pass. The original example has one failure out of 20 on 3.14.4, atud.get('a', '').Python 3.11 wasn't run locally. Its older behavior was checked against the CPython 3.11 implementation and Mapping.get, alongside the 3.12 implementation. This doesn't change the separate missing-key recursion behavior.
Thanks for flagging the version difference.