Repository navigation
Migrate npm publishing to GitHub Actions (npm OIDC) - #4
Merged
Merged
Conversation
- Add publish workflow: build + dry-run publish on PR, build + publish on master
(npm OIDC trusted publishing, id-token: write, Node 24, npm view + patch bump
versioning, job-level concurrency, fail-fast registry lookup)
- Remove .circleci/config.yml (NPM_TOKEN based publishing)
Dry-run error detection matches npm's error prefixes ("npm error" / "npm ERR!")
only, since this package legitimately contains files like ValidationErrorResult.js
that would false-positive a bare "error" grep.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. WalkthroughWarning Review details and warnings were omitted to fit the comment limit. |
Commit fadf0ac (2025-10-21) accidentally deleted package.json, README.md, mocha.opts and src/, docs/, test/ - the generator script deletes these before regeneration but produced no output that day, leaving the repo unpublishable. Restored from 3e1089c, the exact tree the last release (1.0.437) was built from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.github/workflows/publish.yml:npm install->npm run build(babel) ->npm publish --dry-run(validates build + pack; ships nothing)master: same build, then realnpm publish --access publicvia OIDC (id-token: write, Node 24 / npm >= 11.5.1 - no registry token needed)npm view, bumps patch (next release 1.0.438, continuing the1.0.xsequence).circleci/config.yml(NPM_TOKEN-based publishing) - publishing now happens in exactly one placeNotes
@flipdish/api-client-javascript(repoflipdishbytes/api-client-javascript, workflow.github/workflows/publish.yml) before the first publish tomaster.npm error/npm ERR!prefixes only - this package legitimately contains files likeValidationErrorResult.js, which a bareerrorgrep would false-positive on.mastercurrently has nopackage.json(deleted in fadf0ac on 2025-10-21 by a generator run that produced no output), so the PR check will fail until the generator repopulates the repo on its next run - same recovery path the CircleCI pipeline would have needed.update-javascript.shhasgit restore .circleci/config.ymlwhich will now find nothing - harmless (script continues), to be cleaned up in the generator repo separately.Summary by CodeRabbit