This repository was archived by the owner on Aug 31, 2024. It is now read-only.
Fixed jsonp URLs with token authentication - #13
Merged
Conversation
fitzgen
added a commit
that referenced
this pull request
Jan 3, 2012
Fixed jsonp URLs with token authentication
Owner
|
Good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting 401 Unauthorized responses from the api when trying to use any of the jsonp calls that required authentication.
I checked the v2 docs and they say the api token should be passed as the
tokenvariable in the request URL. But github-api was calling itauthTokenin the URL. So, I changed it and everything worked and unicorns waltzed into my office and danced a merry jig.