This repository was archived by the owner on Sep 21, 2021. It is now read-only.
[WIP] Move the logic to load properties of a node to util file.#884
Merged
Conversation
This will allow a consumer (e.g. the debugger) to preload properties of a given root and use them as it wishes (e.g., for the debugger, use all the direct properties as root for the ObjectInspector of the Popup preview).
Member
Author
|
WIP because I need to write the debugger code (which I'll do right away) that would make use of that and validate my assumptions. cc @jasonLaster |
jasonLaster
reviewed
Jan 9, 2018
jasonLaster
left a comment
Contributor
There was a problem hiding this comment.
Looks great, you know that I am a fan of isolating this function
| return getClosestNonBucketNode(parent); | ||
| } | ||
|
|
||
| function loadItemProperties( |
Contributor
There was a problem hiding this comment.
this function could probably be in its own module. It is sufficiently interesting in terms of dependencies and logic
+ const {
+ enumEntries,
+ enumIndexedProperties,
+ enumNonIndexedProperties,
+ getPrototype,
+ enumSymbols,
+ } = require("./client");
+
Member
Author
There was a problem hiding this comment.
what do you mean by own module ?
Member
Author
|
okay, this is working in the debugger, even if it needs a bit too much in my opinion |
jasonLaster
approved these changes
Jan 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow a consumer (e.g. the debugger) to preload properties of a given root
and use them as it wishes (e.g., for the debugger, use all the direct properties as
root for the ObjectInspector of the Popup preview).