Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

[Breakpoints] Show original breakpoint text#6055

Merged
jasonLaster merged 3 commits into
firefox-devtools:masterfrom
jasonLaster:bp-original-text
Apr 23, 2018
Merged

[Breakpoints] Show original breakpoint text#6055
jasonLaster merged 3 commits into
firefox-devtools:masterfrom
jasonLaster:bp-original-text

Conversation

@jasonLaster
Copy link
Copy Markdown
Contributor

Fixes Issue: #6032

Summary of Changes

Previously we were only showing the generated line. Now we show the correct text based on the context

@bomsy
Copy link
Copy Markdown
Contributor

bomsy commented Apr 22, 2018

OOOOoH nice!

@bomsy
Copy link
Copy Markdown
Contributor

bomsy commented Apr 23, 2018

@jasonLaster Found 2 issues

  • When remove and re-add the breakpoints in the original file, the breakpoint text no longer switches correctly (see gif below). Is this a known issue?

  • Minor one, the breakpoint text looses the code styling on context switch.

I can add issues and we can fix separately if you like.

@darkwing
Copy link
Copy Markdown
Contributor

Added two commits:

1 - Ensure the syntax highlighting works upon update
2 - Make it more efficient

@jasonLaster jasonLaster merged commit cd31b65 into firefox-devtools:master Apr 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants