This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Revert "Added VisibilityHandler to handle the mounting and unmounting…#6030
Merged
Merged
Conversation
… of child components of App when changing panel tabs. (firefox-devtools#5688)" This reverts commit ea6e740.
Contributor
|
Tested in panel and scrolling persists. |
darkwing
approved these changes
Apr 20, 2018
Contributor
darkwing
left a comment
There was a problem hiding this comment.
Tested in panel and the scroll position persisted.
jasonLaster
added a commit
to jasonLaster/debugger.html
that referenced
this pull request
Apr 20, 2018
… of child components of App when changing panel tabs. (firefox-devtools#5688)" (firefox-devtools#6030) This reverts commit ea6e740.
Member
|
Great that this managed to be fixed before the end of 61 Nightly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue: #5748
Summary of Changes
Trade-offs