This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Accordion accessibility enhancement#6026
Merged
darkwing merged 7 commits intoApr 19, 2018
Merged
Conversation
Contributor
|
Awesome work here @jawyoonis ! The only update I made was a padding update for RTL languages. If tests pass we'll get this in. AWESOME! |
darkwing
approved these changes
Apr 19, 2018
jasonLaster
pushed a commit
that referenced
this pull request
Apr 21, 2018
* Converted accordian to list * enhance accordion accessiblity * fixed css formatting * removed extra testing code * Remove files that shouldn't have been included * Fix padding for RTL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue: #4080 checkbox #4 -Headers/Panels should at least have list/listitem semantics including expanded and collapsed states.
Summary of Changes
We changed the header panels from divs to lists and we also added aria roles to use list/lisitems for headers/panels.
Test Plan
You can use debugger tool's console to verify that header/panels are now lists and have aria roles.