This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fixes outline issue from our earlier fix to the button#6025
Merged
darkwing merged 10 commits intoApr 20, 2018
Conversation
Contributor
|
Hello @BadInternetGuy! This is one of the weirder issues I've seen in a while. What's causing the problem is
What's weird is why the focusring is stretching the entire height of its neighboring input; if you remove I'm going to play around with this and try to figure it out. |
Contributor
|
OK -- updated to use the |
darkwing
approved these changes
Apr 20, 2018
Contributor
|
Nice work @BadInternetGuy and team! |
jasonLaster
pushed a commit
that referenced
this pull request
Apr 21, 2018
* made a test change * Fixed README * fixed the close button * fixed the close button * changed the div to button in the test cases * Finally fixed the dotted line issue for our button * Fix linting issues * Show better outline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue: #4070
Finally managed to remove the outline from our button.
We simply added a new attribute to the CSS file, namely, adding
outline: none !important;
Before:
After:
