Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

adding DocSearch to the site#6022

Merged
jasonLaster merged 2 commits into
firefox-devtools:masterfrom
s-pace:site/add_search_experience
Apr 19, 2018
Merged

adding DocSearch to the site#6022
jasonLaster merged 2 commits into
firefox-devtools:masterfrom
s-pace:site/add_search_experience

Conversation

@s-pace
Copy link
Copy Markdown
Contributor

@s-pace s-pace commented Apr 19, 2018

Following https://help.github.com/articles/customizing-css-and-html-in-your-jekyll-theme/

Fixes Issue:#5338

Help #5047

Here's the Pull Request Doc
https://devtools-html.github.io/debugger.html/CONTRIBUTING.html#pull-requests

Summary of Changes

I am working at DocSearch and we would love to help you super project!

Screenshots/Videos (OPTIONAL)

You can try it here:

http://debugger-docsearch.surge.sh/

Let me know if you have any feedback

@s-pace
Copy link
Copy Markdown
Contributor Author

s-pace commented Apr 19, 2018

cc @jasonLaster :)

@jasonLaster
Copy link
Copy Markdown
Contributor

so i dont think this fixes #5047, but it definitely addresses #5338.

@jasonLaster
Copy link
Copy Markdown
Contributor

surge.sh is taking awhile, but the code looks good.
could you provide a comment in default.html about where this was copied from and some github docs?

@s-pace
Copy link
Copy Markdown
Contributor Author

s-pace commented Apr 19, 2018

You are right.

Done ✅

@jasonLaster
Copy link
Copy Markdown
Contributor

does this work for you
debugger-docsearch.surge.sh

@s-pace
Copy link
Copy Markdown
Contributor Author

s-pace commented Apr 19, 2018

Now yes, surge had a bad time

@jasonLaster
Copy link
Copy Markdown
Contributor

it's working for me too!

Could we move the search bar into the header so it is available on other pages too?

Screen Shot 2018-04-19 at 10.32.45 AM.png

@jasonLaster
Copy link
Copy Markdown
Contributor

also, did you have a good way of testing this locally, like jekyll start?

@s-pace
Copy link
Copy Markdown
Contributor Author

s-pace commented Apr 19, 2018

Since it is included into the template it will be available everywhere.

No I don't have a proper way so far

@jasonLaster
Copy link
Copy Markdown
Contributor

jasonLaster commented Apr 19, 2018

strange, i didn't see it here:

@s-pace
Copy link
Copy Markdown
Contributor Author

s-pace commented Apr 19, 2018

Because you are redirected to the official website. It is only a showcase on the first page

@jasonLaster jasonLaster merged commit 60b49fd into firefox-devtools:master Apr 19, 2018
@jasonLaster
Copy link
Copy Markdown
Contributor

Great work!

@s-pace
Copy link
Copy Markdown
Contributor Author

s-pace commented Apr 19, 2018

So huge!

Thanks

jasonLaster pushed a commit to jasonLaster/debugger.html that referenced this pull request Apr 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants