This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Changes the close button to an actual button#5991
Merged
Merged
Conversation
Contributor
|
I added two commits:
|
Contributor
|
This is looking really good! A few notes:
.close-btn {
padding: 0;
}I looked at the update in Chrome (we don't officially support using the debugger in Chrome but we do our best) and the "x" somehow doesn't display...until my fix above. Padding saves the day! Once you update padding I think this is good to go! :) . Make sure to pull down my changes |
darkwing
approved these changes
Apr 17, 2018
Contributor
darkwing
left a comment
There was a problem hiding this comment.
I decided to do the honors of removing padding; once tests pass I'll merge. Thank you so much!
jasonLaster
pushed a commit
that referenced
this pull request
Apr 18, 2018
* made a test change * Fixed README * fixed the close button * fixed the close button * changed the div to button in the test cases * Update jest snapshots * Linting fixes * Fix padding
jasonLaster
pushed a commit
that referenced
this pull request
Apr 18, 2018
* made a test change * Fixed README * fixed the close button * fixed the close button * changed the div to button in the test cases * Update jest snapshots * Linting fixes * Fix padding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue: #4070
This changes to div to a button, so that it can work with a screen reader. The padding around the button is still slightly to large, but the button works as needed.
Ctrl+Shift+F to open a search bar.
Press the close button.
Padding makes the button slightly to large.