This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Use pausePoints to determine valid pause locations#5954
Merged
Conversation
d0e584c to
2baaed5
Compare
5414296 to
1fd5a7b
Compare
Contributor
|
Code looks solid; do we have any manual testing steps that can be done reliably? |
darkwing
approved these changes
Apr 17, 2018
Contributor
darkwing
left a comment
There was a problem hiding this comment.
Approved under the condition you (1) remove find and (2) back out the package.json/yarn.lock updates as they're already in.
| import type { SimplePath } from "./utils/simple-path"; | ||
|
|
||
| const isForStatement = node => | ||
| t.isForStatement(node) || t.isForOfStatement(node); |
Contributor
Author
|
manually uses babel-stepping |
1fd5a7b to
f27db22
Compare
jasonLaster
added a commit
that referenced
this pull request
Apr 18, 2018
jasonLaster
added a commit
that referenced
this pull request
Apr 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue: #5951
Summary of Changes