This repository was archived by the owner on Jan 11, 2023. It is now read-only.
(WIP) Migrate source maps#5824
Merged
jasonLaster merged 1 commit intoApr 23, 2018
Merged
Conversation
95c0e11 to
c1125d9
Compare
Contributor
|
Where are we on this @jasonLaster and what's the priority? Only |
Contributor
Author
|
It's close. just have to test how the release process would go... but it's basically ready, next time i have some time |
Contributor
Author
|
will pick this up in paris |
c1125d9 to
6138d5d
Compare
nchevobbe
reviewed
Apr 23, 2018
nchevobbe
left a comment
Member
There was a problem hiding this comment.
I guess we should somehow run devtools-source-map tests in CI
| "devtools-linters": "^0.0.4", | ||
| "devtools-reps": "^0.22.0", | ||
| "devtools-source-map": "^0.16.0", | ||
| "devtools-source-map": "0.16.0", |
Member
There was a problem hiding this comment.
should we add a comment saying the version number will be ignored because we use workspaces ?
Contributor
Author
There was a problem hiding this comment.
its json, no comments, also no fun
6138d5d to
70c6f1c
Compare
70c6f1c to
02e7b7d
Compare
nchevobbe
approved these changes
Apr 23, 2018
jasonLaster
added a commit
that referenced
this pull request
Apr 24, 2018
jasonLaster
added a commit
that referenced
this pull request
Apr 27, 2018
jasonLaster
added a commit
that referenced
this pull request
May 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #5820
Summary of Changes
Local Changes
Next Steps
yarn testand circleci