Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

update file icons to use img instead of svg#5709

Merged
bomsy merged 1 commit into
firefox-devtools:masterfrom
hozefaj:svg-to-img
Mar 18, 2018
Merged

update file icons to use img instead of svg#5709
bomsy merged 1 commit into
firefox-devtools:masterfrom
hozefaj:svg-to-img

Conversation

@hozefaj

@hozefaj hozefaj commented Mar 17, 2018

Copy link
Copy Markdown

Fixes Issue: #5658

Here's the Pull Request Doc
https://devtools-html.github.io/debugger.html/CONTRIBUTING.html#pull-requests

Summary of Changes

  • changing svg icons for multiple files into img tags to help with performance gains

Test Plan

Tell us a little a bit about how you tested your patch.

Example test plan:

  • Command-P opens the panel
  • Clicking “+” opens the panel
  • Clicking a source navigates to the source
  • Clicking "x" closes the panel

Here's the Debugger's Testing doc
https://docs.google.com/document/d/1oBMRxV8A2ag2t22YsQOxTdEv0mXKzIg0tggJjRkU1S0/edit#.
Feel free to improve it!

@bomsy

bomsy commented Mar 18, 2018

Copy link
Copy Markdown
Contributor

Nice one @hozefaj congrats on your first PR!

@bomsy bomsy merged commit 64ecbf1 into firefox-devtools:master Mar 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants