Render a toggle for original/generated scopes when available.#5702
Conversation
abab84b to
df78803
Compare
| this.setState({ showOriginal: !showOriginal }); | ||
| }} | ||
| > | ||
| Show {showOriginal ? "generated" : "original"} scope |
There was a problem hiding this comment.
hmm, i think we should have two strings in assets/panel/debugger.properties not a big deal... See 115 for the L10.getStr api
| hasOriginalScopes: | ||
| isLoading || !generatedFrameScopes || !frameScopes | ||
| ? false | ||
| : generatedFrameScopes.actor !== frameScopes.actor |
There was a problem hiding this comment.
hmm, this seems like something that we should have in reducers/pause so that the mochitests can also listen for it to. Also hides some complexity.
If the state doesnt all come from reducers/pause, it can go in selectors/hasOriginalScopes.js
|
@jasonLaster Do we want to hide this behind a pref? Is this something most users will want? |
|
@darkwing good point. this should use the |
|
@darkwing @jasonLaster The toggle only shows up if there are original scopes, so it should already be hidden based on that flag since there aren't original scopes when the flag is off. |
| scopes.notPaused=Not paused | ||
|
|
||
| # LOCALIZATION NOTE (scopes.toggleToGenerated): Scopes right sidebar pane label | ||
| # for link to change scope list to show scopes for generated code. |
There was a problem hiding this comment.
I think both comments need some rewording, but I'm not sure I can help a lot, not being familiar with the matter. E.g. "Link displayed in the right sidebar to display scopes for generated code" makes sense?
There was a problem hiding this comment.
Haha, yeah that's what I get for copy/pasting half the text from the one above this :P
Refs Issue: #5561
Summary of Changes
Screenshots/Videos (OPTIONAL)