This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Highlight all text on watch expression edit#5226
Merged
wldcordeiro merged 3 commits intoJan 29, 2018
Merged
Conversation
Contributor
|
looks great. It would be nice to have a comment on what the code is trying to do :) |
Contributor
Author
|
Hehe, I thought we hate comments :P |
Contributor
|
this is the exception to the rule lol |
Contributor
|
do we need to touch SearchInput? |
Contributor
|
CC @Loirooriol |
Contributor
Author
|
It's already a one-time thing in |
Contributor
Author
|
We should probably make this a helper function, |
Contributor
|
Moving the cursor to the end when edition starts also seems a bit arbitrary. Selecting all the text may be more useful, this way you can just start typing and replace the old expression with the new one. |
Contributor
|
I think given that we're double clicking to edit the user would expect the text to be highlighted. |
Contributor
Author
|
|
Contributor
|
🔥 |
wldcordeiro
approved these changes
Jan 29, 2018
jasonLaster
pushed a commit
that referenced
this pull request
Jan 29, 2018
* Put the cursor at end only once on watch expression edit * comment to understand whats going on * highlight text on edit watch expression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #5220
Screenshots/Videos (OPTIONAL)