Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Calls the correct pause info#5217

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
lukaszsobek:testing-promise-fail-5185
Jan 28, 2018
Merged

Calls the correct pause info#5217
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
lukaszsobek:testing-promise-fail-5185

Conversation

@lukaszsobek

@lukaszsobek lukaszsobek commented Jan 26, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Associated Issue: #5185

  • A non-existent pauseInfo was called which resulted in an empty selector and the test passing with an error in the console despite the generatedSourceRecord in fetchScopes.js being undefined. It seems the test now fails like it should.

@jasonLaster jasonLaster merged commit e17bca9 into firefox-devtools:master Jan 28, 2018
@jasonLaster

jasonLaster commented Jan 28, 2018

Copy link
Copy Markdown
Contributor

Nice work!

@lukaszsobek lukaszsobek deleted the testing-promise-fail-5185 branch January 29, 2018 06:17
jasonLaster pushed a commit that referenced this pull request Jan 29, 2018
@jasonLaster
Calls the correct pause info (#5217)
095ab69
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jasonLaster jasonLaster jasonLaster approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukaszsobek @jasonLaster