This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Re-add other tests#5208
Merged
Merged
Conversation
| - node ./bin/ci/check-file-sizes.js | ||
| - ./node_modules/.bin/mochii --ci --mc ./firefox --headless devtools/client/debugger/new | ||
| - ./node_modules/.bin/mochii --ci --mc ./firefox --headless | ||
| browser_toolbox_debugger.js |
Member
There was a problem hiding this comment.
the real name of the test is browser_browser_toolbox_debugger.js (and it will time out until we have a m-c changeset with the fix from https://bugzilla.mozilla.org/show_bug.cgi?id=1432842)
Member
I still see the tests in tree. Are we missing a commit? Edit: Oh, you got rid of the file entirely. |
Member
f458354 to
313898e
Compare
jasonLaster
added a commit
that referenced
this pull request
Jan 26, 2018
jasonLaster
added a commit
that referenced
this pull request
Jan 26, 2018
jasonLaster
added a commit
that referenced
this pull request
Jan 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@juliandescottes recently added other tests that touched the debugger
I had to take them out because the way they were setup were timing out... Here's a new branch that attempts to land them so that they all run