CI: add mochitests using the debugger and located in non-debugger test suites#5197
Conversation
| "devtools/client/framework/test/browser_source_map-01.js", | ||
| "devtools/client/framework/test/browser_source_map-absolute.js", | ||
| "devtools/client/framework/test/browser_source_map-init.js", | ||
| "devtools/client/framework/test/browser_source_map-inline.js", |
There was a problem hiding this comment.
are the source-map tests all using the debugger?
There was a problem hiding this comment.
They need a toolbox and to do so they open it on the debugger. I assumed they needed to start the debugger for the tests to work. But starting the toolbox on any other tool seems to be sufficient to make the tests pass. I'll remove those.
There was a problem hiding this comment.
I'd rather not include them, because a smaller list is easier...
we can always re-consider if they fail in a release :P
| "devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_eval_in_debugger_stackframe1.js", | ||
| "devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_eval_in_debugger_stackframe2.js", | ||
| "devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_location_debugger_link.js", | ||
| "devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_stacktrace_location_debugger_link.js", |
There was a problem hiding this comment.
Ah yes there seems to at least be one: devtools/client/inspector/markup/test/browser_markup_links_06.js not sure how I missed it my first pass. Thanks!
|
|
||
| const otherTests = [ | ||
| "browser_net_open_in_debugger.js" | ||
| "devtools/client/framework/test/browser_browser_toolbox_debugger.js", |
15e5c4e to
41f178c
Compare
|
Fixed a typo + applied comments |
|
We should have at least one failure here, we will need a m-c changeset with my patch from https://bugzilla.mozilla.org/show_bug.cgi?id=1432842 before browser_browser_toolbox_debugger.js can pass. |
41f178c to
bfb1281
Compare
|
I hadn't updated the PR by commenting out the failing test, so I don't know if the timeout is related to setup issues. |
WIP.
Added all the tests I could find the devtools that rely on the new debugger. In theory they should all be tested as well. If it increases the testing time too much, we can look in more details on try to remove tests that seem redundant regarding their usage of the debugger.
Let's see what the CI says.