This repository was archived by the owner on Jan 11, 2023. It is now read-only.
🔧: Fixing Jest coverage collection and cleaning up config for Jest 22 prep#5193
Merged
jasonLaster merged 1 commit intoJan 25, 2018
Merged
Conversation
…for Jest 22 This fixes the coverage collection so it is looking at more of our source. Sadly this means our 62% coverage was really 43% but now we have that knowledge!
jasonLaster
reviewed
Jan 25, 2018
Contributor
jasonLaster
left a comment
There was a problem hiding this comment.
looking good. Why do we delete some of these test files?
Contributor
Author
|
@jasonlaster11 the only file I deleted was the tests-framework file but I moved its content to tests-setup since both were only preparing the Jest environment. |
Contributor
|
weird it looks like some specs were deleted |
Contributor
Author
|
Nah I just renamed a few that were missing the ".spec.js" in their name. |
jasonLaster
pushed a commit
that referenced
this pull request
Jan 26, 2018
jasonLaster
pushed a commit
that referenced
this pull request
Jan 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #5100
Summary of Changes
collectCoverageFromto the Jest config to get a more accurate report.spec.jspattern we've moved toSad but good news, our coverage dropped from ~62% to ~43%, it's lame to see a lower number but it's more accurate so it's a win in the long run!