This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fix syncing breakpoints when bps are removed#5176
Merged
bomsy merged 1 commit intoJan 24, 2018
Merged
Conversation
52309a4 to
bd1bc06
Compare
bd1bc06 to
a0a7667
Compare
a0a7667 to
bc07f56
Compare
bomsy
approved these changes
Jan 24, 2018
jasonLaster
added a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jan 25, 2018
jasonLaster
added a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jan 25, 2018
…-devtools#5176)" This reverts commit e79b8f1.
jasonLaster
added a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jan 26, 2018
…-devtools#5176)" This reverts commit e79b8f1.
jasonLaster
added a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jan 26, 2018
…-devtools#5176)" This reverts commit e79b8f1.
jasonLaster
added a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jan 26, 2018
…-devtools#5176)" This reverts commit e79b8f1.
jasonLaster
added a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jan 26, 2018
…-devtools#5176)" This reverts commit e79b8f1.
jasonLaster
added a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jan 26, 2018
…-devtools#5176)" This reverts commit e79b8f1.
jasonLaster
added a commit
that referenced
this pull request
Jan 26, 2018
This reverts commit e79b8f1.
jasonLaster
added a commit
that referenced
this pull request
Jan 26, 2018
This reverts commit e79b8f1.
jasonLaster
added a commit
that referenced
this pull request
Jan 26, 2018
This reverts commit e79b8f1.
jasonLaster
added a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jan 27, 2018
…-devtools#5176)" This reverts commit e79b8f1.
jasonLaster
added a commit
that referenced
this pull request
Jan 27, 2018
This reverts commit e79b8f1.
jasonLaster
added a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jan 29, 2018
…irefox-devtools#5176)"" This reverts commit 6247e67.
jasonLaster
added a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jan 29, 2018
…irefox-devtools#5176)"" This reverts commit 6247e67.
jasonLaster
added a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jan 29, 2018
…irefox-devtools#5176)"" This reverts commit 6247e67.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3982
Summary of Changes
When the breakpoint is at an original location that is no longer mapped to a generated source we want to remove it. In those cases we need to make sure that the breakpoint is removed from the breakpoint redux & client store.