Disable CSS auto-prefixes for old IE#5168
Conversation
|
What would you say were the benefits of the change? |
|
@lukaszsobek I think there will be a very very tiny increase in building speed, smaller build size. And there will be no old prefixes, which are not needed for newest browsers. |
| require("postcss-bidirection"), | ||
| require("autoprefixer"), | ||
| require("autoprefixer")({ | ||
| browsers: ['> 3%', 'not ie <= 10'], |
There was a problem hiding this comment.
Haha yeah. Let’s do latest chrome and latest Firefox
There was a problem hiding this comment.
should I change this to ['last 2 Firefox versions', 'last 2 Chrome versions'] ?
note: browser list is there: https://github.com/ai/browserslist#queries
| require("postcss-bidirection"), | ||
| require("autoprefixer"), | ||
| require("autoprefixer")({ | ||
| browsers: ['last 2 Firefox versions', 'last 2 Chrome versions'], |
There was a problem hiding this comment.
should this be "browserslist: [ ..." rather than "browsers: [ ..."?
There was a problem hiding this comment.
| require("postcss-bidirection"), | ||
| require("autoprefixer"), | ||
| require("autoprefixer")({ | ||
| browsers: ['last 2 Firefox versions', 'last 2 Chrome versions'], |
There was a problem hiding this comment.
While we technically only support Firefox and Chrome you could just make this the 'last 2 version' value instead of explicitly just Firefox/Chrome.
|
Looks good to me. I prefer being explicit because who knows what other features other browsers are missing :) |
Summary of Changes
I think a majority of user use modern browsers for running this debugger, so some prefixes for really old browsers are not needed.
Test Plan
Screenshots/Videos (OPTIONAL)