[Sources] - fix paddings in sources tree and outline list#5167
Conversation
|
An after image is always nice, as it allows to compare changes visually ;) |
|
@lukaszsobek sure,I added screenshots to description |
|
@lukaszsobek I fixed right paddings in lists and finded solution for #5149 |
jasonLaster
left a comment
There was a problem hiding this comment.
Thanks! The tree looks great after your change
| min-width: 100%; | ||
|
|
||
| display: grid; | ||
| align-content: start; |
There was a problem hiding this comment.
this will fix bug #5149, basically, this will extend items in the tree to full width. I don't know why, but width: 100% or display: flex was not able to fix the issue.
There was a problem hiding this comment.
On the current update of master the line already seems to be the full width, so not sure if this is needed.
There was a problem hiding this comment.
The problem appears when you have long and short short names on the list, and try to vertically scroll, as you can see in the gif.
|
Thanks for the fix! Looks great |
…refox-devtools#5167)" This reverts commit b892892.
…refox-devtools#5167)" This reverts commit b892892.
)" This reverts commit b892892.
|
Hey @martinfojtik, I'm sorry to do this to you but I had to revert your commit earlier today because it was causing an issue with travis CI. Earlier this week we had false positives with CI, where the tests were failing but not reporting that. Would you be able to re-open the PR and we can sort out the problem? |
|
Hi, @jasonLaster , where can I find more info about the problem? How do i re-open this PR? |
|
you revert the reverted commit and open a new PR. My theory is that display grid was throwing off the linux version of firefox. will test that now in a new PR |
…list (firefox-devtools#5167)"" This reverts commit 2f5a72b.
…list (firefox-devtools#5167)"" This reverts commit 2f5a72b.
…list (firefox-devtools#5167)"" This reverts commit 2f5a72b.
…list (firefox-devtools#5167)"" This reverts commit 2f5a72b.
Summary of Changes
Test Plan
Screenshots/Videos (OPTIONAL)