[Project Search] Fix duplicate sources#5165
Conversation
|
Looks great. I'll review more fully tuesday |
| .filter(source => isLoaded(source) && !isThirdParty(source)); | ||
| .filter(source => !isThirdParty(source)); | ||
| for (const source of validSources) { | ||
| await dispatch(loadSourceText(source)); |
There was a problem hiding this comment.
loadSourcetext calls isLoaded anyway, nice.
| await dispatch(clearSearchResults()); | ||
| await dispatch(addSearchQuery(query)); | ||
| dispatch(updateSearchStatus(statusType.fetching)); | ||
| await dispatch(loadAllSources()); |
There was a problem hiding this comment.
Like the shift in approach. Instead of loading everything up front we load them one by one.
|
Maybe we should move |
|
Edit: read comment below. If we don't already have one it would be great to have a test that checks if the status is correctly updated after all sources were loaded. |
|
@lukaszsobek I did the |
|
Hey @jbhoosreddy, @AlexisDeschamps could you do a rebase here when you have a chance |
Fixed duplicate sources bug Fixed lint
…plicates sources fix.
|
@jasonLaster I completed a rebased. |
#5159
Summary of Changes
loadAllFilesmethodsearchSourcesTest Plan
Screenshots
Before:
After:
