Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Improve Breakpoint Syncing#5160

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
jasonLaster:fix-syncing-disabled-bp2
Jan 24, 2018
Merged

Improve Breakpoint Syncing#5160
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
jasonLaster:fix-syncing-disabled-bp2

Conversation

@jasonLaster
Copy link
Copy Markdown
Contributor

@jasonLaster jasonLaster commented Jan 20, 2018

Associated Issue: #5140

Summary

  1. Adds an integration test w/ 3 versions of the same original file
  2. Adds a check for clearing null mapped generated lines, this check removes a breakpoint in the mochitest when the line the breakpoint is on no longer exists!!!

@jasonLaster jasonLaster force-pushed the fix-syncing-disabled-bp2 branch 4 times, most recently from 6768855 to 5da26b4 Compare January 23, 2018 14:25
await addBreakpoint(dbg, "sjs_code_reload", 2);


debugger;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to take out after ..

const breakpointList = breakpoints.valueSeq().toJS();
const breakpoint = breakpointList[0];

debugger;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this ..

@bomsy
Copy link
Copy Markdown
Contributor

bomsy commented Jan 23, 2018

This looks good ... just a couple of failing tests atm

@jasonLaster jasonLaster force-pushed the fix-syncing-disabled-bp2 branch from 5da26b4 to b6518a0 Compare January 24, 2018 00:53
Add sourcemap reloading integration test
@jasonLaster jasonLaster force-pushed the fix-syncing-disabled-bp2 branch from b6518a0 to 3c1207d Compare January 24, 2018 00:54
@jasonLaster jasonLaster merged commit 9d8687e into firefox-devtools:master Jan 24, 2018
jasonLaster added a commit to jasonLaster/debugger.html that referenced this pull request Jan 25, 2018
jasonLaster added a commit that referenced this pull request Jan 26, 2018
jasonLaster added a commit that referenced this pull request Jan 27, 2018
jasonLaster added a commit to jasonLaster/debugger.html that referenced this pull request Jan 27, 2018
jasonLaster added a commit that referenced this pull request Jan 27, 2018
jasonLaster added a commit to jasonLaster/debugger.html that referenced this pull request Jan 29, 2018
jasonLaster added a commit to jasonLaster/debugger.html that referenced this pull request Jan 29, 2018
jasonLaster added a commit that referenced this pull request Jan 29, 2018
jasonLaster added a commit that referenced this pull request Jan 29, 2018
jasonLaster added a commit that referenced this pull request Feb 14, 2018
jasonLaster added a commit that referenced this pull request Feb 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants