This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Use pushPref helper in mochitests to set temporary pref values#5128
Merged
jasonLaster merged 1 commit intoJan 17, 2018
Merged
Conversation
c09f121 to
afaddd8
Compare
Member
Author
|
Can't use it for |
jasonLaster
pushed a commit
that referenced
this pull request
Jan 24, 2018
jasonLaster
pushed a commit
that referenced
this pull request
Feb 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the pushPref helper whenever possible in mochitests, otherwise the preference changes leak from one test to another.
Also simplified some tests that used to set the preference and restore it on cleanup. First, there was no added value compared to pushPref. Secondly, the restore was not wrong. It should restore to the original value (read at the beginning of the test) rather than to a random set value (eg. false).
Let's see if tests still pass.