This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Cleanup Preview#5078
Merged
jasonLaster merged 2 commits intoJan 18, 2018
Merged
Conversation
bomsy
reviewed
Jan 11, 2018
| tokenPos, | ||
| cursorPos, | ||
| extra | ||
| ...action.value, |
bomsy
reviewed
Jan 11, 2018
| renderFunctionPreview() { | ||
| const { selectSourceURL, value } = this.props; | ||
| const { location } = value; | ||
| const root = this.getRoot(); |
Contributor
There was a problem hiding this comment.
this root here does not seem to be used within this function
e3ce998 to
402ed4e
Compare
bomsy
approved these changes
Jan 16, 2018
402ed4e to
39e4bfb
Compare
jasonLaster
added a commit
that referenced
this pull request
Jan 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes