This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Prevent unecessary renders#4735
Merged
Merged
Conversation
Contributor
|
This is a really cool optimization for making sure React doesn't think things have changed 😄 |
jasonLaster
commented
Nov 20, 2017
| const emptySourceMetaData = {}; | ||
| export function getSourceMetaData(state: OuterState, sourceId: string) { | ||
| return state.ast.getIn(["sourceMetaData", sourceId]) || {}; | ||
| return state.ast.getIn(["sourceMetaData", sourceId]) || emptySourceMetaData; |
Contributor
Author
There was a problem hiding this comment.
i bet getIn takes a default arg
Contributor
|
looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4692
Summary of Changes
Testing
I'd like to add a unit test that adds a source and checks to make sure the editor did not render.