Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Pause on Exceptions dropdown#4729

Merged
jasonLaster merged 25 commits into
firefox-devtools:masterfrom
GarethSharpe:new-dropdown
Nov 18, 2017
Merged

Pause on Exceptions dropdown#4729
jasonLaster merged 25 commits into
firefox-devtools:masterfrom
GarethSharpe:new-dropdown

Conversation

@GarethSharpe

@GarethSharpe GarethSharpe commented Nov 18, 2017

Copy link
Copy Markdown
Contributor

Associated Issue: #4410

Summary of Changes

  • Added icon prop to dropdown (every dropdown requires icon input)
  • Breakpoint dropdown (BD) toggle .svg to "+"
  • BD returns dropdown of breakpoint actions
  1. Pause on next statement
  2. Pause on exceptions
  3. Pause on uncaught exceptions
  4. Ignore exceptions

Test plan:

  • Clicking '+' in the breakpoints pane toggles the BD
  • Clicking an action causes .svg image highlight
  • Clicking an action also causes '+' image highlight
  • Selected action executes on exception (or exception is ignored)
  • Resuming program execution allows program to continue until next exception
  • Clicking '+' again (without selecting an action) closes the BD

TODO:

  • Adjust dropdown width to fit parent
  • Remove dropdown scroll-bars
  • Update L10N.getStr for each dropdown option
  • Add menu items (with corresponding images)
  • Add menu item implementation
  • Add hover animation
  • Change Svg implementation of dbgButton to img (to accommodate mask)
  • '+' icon highlights when in execution state (when execption are not ignored)
    - [ ] Remove CommandBar options as needed
  • Add dropdown as feature and toggle command bar feature as needed

@GarethSharpe

Copy link
Copy Markdown
Contributor Author

Dropdown Default
default

Dropdown with Selection
selection

@jasonLaster jasonLaster merged commit 8cf3da0 into firefox-devtools:master Nov 18, 2017
@GarethSharpe GarethSharpe deleted the new-dropdown branch November 21, 2017 17:59
@jasonLaster jasonLaster changed the title New dropdown Pause on Exceptions dropdown Nov 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants