Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

4651-call-stack-should-not-open-automatically#4672

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
Fischer-L:4651-call-stack-should-not-open-automatically
Nov 14, 2017
Merged

4651-call-stack-should-not-open-automatically#4672
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
Fischer-L:4651-call-stack-should-not-open-automatically

Conversation

@Fischer-L

Copy link
Copy Markdown
Contributor

Associated Issue: #4651

Summary of Changes

Make the call stack not open automatically on pause

@Fischer-L

Copy link
Copy Markdown
Contributor Author

@jasonLaster a PR for #4651 , please have a look thanks

@bomsy

bomsy commented Nov 11, 2017

Copy link
Copy Markdown
Contributor

@Fischer-L a tiny lint issue
image

@bomsy

bomsy commented Nov 11, 2017

Copy link
Copy Markdown
Contributor

We might also need to update some of the mochitests

@Fischer-L Fischer-L force-pushed the 4651-call-stack-should-not-open-automatically branch from 12f3fe7 to ee0405c Compare November 14, 2017 13:20
@Fischer-L

Copy link
Copy Markdown
Contributor Author

We might also need to update some of the mochitests

Thanks for reminding. Updated. Should be ok, wait for the test runs.

@Fischer-L Fischer-L force-pushed the 4651-call-stack-should-not-open-automatically branch from ee0405c to e0e40ef Compare November 14, 2017 13:23

@jasonLaster jasonLaster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@jasonLaster jasonLaster merged commit 94e13de into firefox-devtools:master Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants