Converted tab, breakpoint, watch expression, and search bar Close Button SVG's to Images#4600
Conversation
|
@jasonLaster how do we go about finishing this up? I believe the snapshots failed in testing. Shall we fix? |
|
will look today |
|
Hey @jselmani just looked and saw some differences in the dark theme:
newold |
|
pushed snapshots, noticed some of the lets try looking at what the old CSS did to line it up because this is tough to get right and keep right :) we've broken it many times |
|
It looks good; this might need a rebase, im seeing an unrelated linting error |
|
The lint error is a mispelling in the mochitest readme. Not caused by these changes and safe to merge since this won't overwrite that at all. |
|
Yes, I also pointed this out. but it isn't good practice to merge a branch with something failing even if it isn't related to the changes of this branch. if we start doing this we become sloppy, and it becomes easy to miss true failures. It is better to be strict for this reason. |
Associated Issue: #4350
Summary of Changes
I used the close button styling from the Atom text editor. Their close button change in color when they are hovered over. A GIF follows for representation:
Screenshots/GIF's
Source Tabs
Watch Expressions/Breakpoints
Find In Files
Source File Search