Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Disallow uncaught exceptions #4584

Merged
jasonLaster merged 1 commit into from
Nov 6, 2017
Merged

Disallow uncaught exceptions #4584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/actions/tests/pause.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import {
actions,
selectors,
createStore,
getHistory
getHistory,
makeSource

@jimblandy jimblandy Nov 6, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these calls fixes for errors that had been previously being ignored? Usually one should submit unrelated fixes as a separate PR, and treat the harness fixes as blocked on that.

@jasonLaster jasonLaster Nov 6, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, this is a tad lazy...

I don't think we gain anything in version control land by doing that though here

} from "../../utils/test-head";

const { isStepping } = selectors;
Expand Down Expand Up @@ -43,6 +44,7 @@ describe("pause", () => {
const { dispatch, getState } = createStore(mockThreadClient);
const mockPauseInfo = createPauseInfo();

await dispatch(actions.newSource(makeSource("foo1")));
await dispatch(actions.paused(mockPauseInfo));
const stepped = dispatch(actions.stepIn());
expect(isStepping(getState())).toBeTruthy();
Expand All @@ -66,6 +68,7 @@ describe("pause", () => {
const { dispatch } = createStore(mockThreadClient);
const mockPauseInfo = createPauseInfo();

await dispatch(actions.newSource(makeSource("foo1")));
await dispatch(actions.paused(mockPauseInfo));
await dispatch(actions.resumed());

Expand All @@ -74,6 +77,8 @@ describe("pause", () => {

it("resuming when not paused", async () => {
const { dispatch } = createStore(mockThreadClient);

await dispatch(actions.newSource(makeSource("foo1")));
await dispatch(actions.resumed());
expect(getHistory("RESUME").length).toEqual(0);
});
Expand Down
2 changes: 1 addition & 1 deletion src/client/firefox/tests/onconnect.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const debuggerClient = {
const actions = {
_sources: [],
connect: () => {},

setWorkers: () => {},
newSources: function(sources) {
return new Promise(resolve => {
setTimeout(() => {
Expand Down
1 change: 1 addition & 0 deletions src/test/tests-setup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,5 @@ setConfig(config);

process.on("unhandledRejection", (reason, p) => {
console.log("Unhandled Rejection at:", p, "reason:", reason);
throw reason;

@jimblandy jimblandy Nov 6, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thousand times yes.

});