This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Style line numbers in search results#4541
Merged
wldcordeiro merged 2 commits intoNov 2, 2017
Merged
Conversation
Contributor
Author
|
I have been trying to understand the file structure for the And, the What is the best way to drop this in
|
jasonLaster
approved these changes
Oct 31, 2017
Contributor
|
deferring to @wldcordeiro |
Contributor
|
I like the change. It looks nice! The CI failure is legit but it's an easy fix. Change this line's assertion https://github.com/devtools-html/debugger.html/blob/master/src/test/mochitest/browser_dbg-quick-open.js#L102 // from
results.forEach(result => is(result.textContent, "x:13"));
// to
results.forEach(result => is(result.textContent, "x13")); |
Contributor
Contributor
|
Hmm, i like that wellington, but lets hold off on that for now VS Code is more compact and i think we should stick to one thing at a time |
wldcordeiro
suggested changes
Nov 2, 2017
wldcordeiro
left a comment
Contributor
There was a problem hiding this comment.
Just need the tweak to the mochitest file mentioned. But ready to go!
wldcordeiro
approved these changes
Nov 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Associated Issue: #4488
Summary of Changes
:is removed from the line numbers in search resultsBefore
After