Changed K+ to K?#4273
Conversation
codehag
left a comment
There was a problem hiding this comment.
thanks for the pr! a couple of issues, lets discuss :)
| renderVerticalLayout: Function; | ||
| toggleSymbolModal: Function; | ||
| onEscape: Function; | ||
| onCommandSlash: Function; |
There was a problem hiding this comment.
we have this work done in https://github.com/devtools-html/debugger.html/pull/4265/files. so lets remove these changes from this PR :)
| flex: 0 0 29px; | ||
| border-bottom: 1px solid var(--theme-splitter-color); | ||
| display: flex; | ||
| justify-content: flex-end; |
There was a problem hiding this comment.
this also moves all of the stepping buttons over to the right hand side of the bar, which is not something we want to do right now. lets remove this rule
| return ( | ||
| <button className={classnames(type, className)} {...props}> | ||
| <Svg name={type} /> | ||
| K? |
There was a problem hiding this comment.
I was thinking that the button could be a simple ? (since im used to it from other editors) with no K (since K is not necessarily meaningful).. not sure, what do you think?
|
Hey @Subtlesnow do you think you'll have time to make these changes? |
|
Yes I should be able to fix them in the next week.
…On Wed, Oct 4, 2017 at 11:02 PM, Jason Laster ***@***.***> wrote:
Hey @Subtlesnow <https://github.com/subtlesnow> do you think you'll have
time to make these changes?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4273 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APJWydmwnpi4CxTsmaZUPyzsEnL660DEks5spEbTgaJpZM4Ps8lD>
.
|
|
Thanks @Subtlesnow! |
|
Hey @Subtlesnow how's your availability? |
|
Hello,
I apologize for getting around to fixing those bugs. I have been very busy
this past week.
…On Wed, Oct 11, 2017 at 9:04 AM, Jason Laster ***@***.***> wrote:
Hey @Subtlesnow <https://github.com/subtlesnow> how's your availability?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4273 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APJWyXo37T6ZgGAXcLX5Z-Z2wBsnkF65ks5srLzwgaJpZM4Ps8lD>
.
|
wldcordeiro
left a comment
There was a problem hiding this comment.
Remove the package-lock.json file. We're using yarn's lockfile. On that note should we .gitignore the package-lock.json file to avoid this in the future @jasonLaster
|
Hey @Subtlesnow, I re-opened your PR on #4382 w/ some small tweaks. Thanks for the help at the meetup! |
Associated Issue: #4213
Here's the Pull Request Doc
https://devtools-html.github.io/debugger.html/CONTRIBUTING.html#pull-requests
Summary of Changes