Breakpoint contextmenu: add "Add/Edit breakpoint condition"#4094
Breakpoint contextmenu: add "Add/Edit breakpoint condition"#4094nyrosmith wants to merge 3 commits into
Conversation
| accesskey: editConditionKey, | ||
| click: () => toggleConditionalBreakpointPanel(breakpoint.location.line) | ||
| label: addOrEditConditionLabel, | ||
| accesskey: addOrEditConditionKey, |
There was a problem hiding this comment.
I think we should have two separate labels "Add Condition", "Edit Condition" that we toggle based on whether there is a condition. We do the same thing when you right click on the gutter.
| click: () => { | ||
| const sourceId = breakpoint.location.sourceId; | ||
| const line = breakpoint.location.line; | ||
| this.props.selectSource(sourceId, { line }); |
There was a problem hiding this comment.
yes! good catch. Perhaps we move this invokation to this action: toggleConditionalBreakpointPanel
|
|
| @@ -119,8 +120,14 @@ export function clearHighlightLineRange() { | |||
| } | |||
|
|
|||
| export function toggleConditionalBreakpointPanel(line: null | number) { | |||
There was a problem hiding this comment.
@nyrosmith the flow issue had to do with the line input
This should fix it export function toggleConditionalBreakpointPanel(line?: number) {
There was a problem hiding this comment.
Thanks @bomsy for looking at it and helping me out!
|
/remind me to finish this PR tomorrow |
|
Closing because of #4157 |
Associated Issue: NONE
@jasonLaster suggested this feature on slack
Summary of Changes