Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Update travis#4054

Merged
jasonLaster merged 2 commits into
firefox-devtools:masterfrom
jasonLaster:update-travis
Sep 17, 2017
Merged

Update travis#4054
jasonLaster merged 2 commits into
firefox-devtools:masterfrom
jasonLaster:update-travis

Conversation

@jasonLaster

@jasonLaster jasonLaster commented Sep 16, 2017

Copy link
Copy Markdown
Contributor

update the travis setup:

  • build and copy the assets
  • use mochi

drop circle mochitest support (will speed up the builds)

@jasonLaster

Copy link
Copy Markdown
Contributor Author

Thanks @Fischer-L, I'm adding @darkwing as a reviewer

@jasonLaster jasonLaster force-pushed the update-travis branch 5 times, most recently from 3540aa0 to e1d2904 Compare September 17, 2017 19:32
@jasonLaster jasonLaster merged commit 02c7abe into firefox-devtools:master Sep 17, 2017
@Fischer-L

Fischer-L commented Sep 18, 2017

Copy link
Copy Markdown
Contributor

Thanks @Fischer-L, I'm adding @darkwing as a reviewer

@jasonLaster My PR is #4057 so I guess #4057 is what you mean right? Thanks

@jasonLaster

Copy link
Copy Markdown
Contributor Author

oops :)

@ochameau ochameau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't understood it was working for real, like, in production.
With documentation and scripts to help running them locally.
That's really fantastic!

Comment thread .travis.yml
global:
- DISPLAY=':99.0'
- YARN_VERSION='0.24.5'
- MC_COMMIT='abd295766dfe'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you now able to bump this m-c changeset easily/frequently?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. It's fixed so that we always get a good artifact build though

Comment thread bin/ci/clone-gecko.sh

cd firefox
hg co $MC_COMMIT
cd ..

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be great to use bin/prepare-mochitests-dev
so that CI and contributors go through the same path.

But given this change, it looks like you had issue with keeping m-c clone around between two travis runs?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, caching was an issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants