This repository was archived by the owner on Jan 11, 2023. It is now read-only.
fix project search intermittent#3661
Merged
jasonLaster merged 1 commit intoAug 14, 2017
Merged
Conversation
codehag
approved these changes
Aug 14, 2017
| Here are a few tips for writing mochitests: | ||
|
|
||
| * There are lots of great helper methods in [head] | ||
| * Try to write async user actions that involve a user action like clicking a button or typing a key press followed by a redux action to listen for. For example, the user step in action involvesthe user clicking the step in button followed by the "stepIn" action firing. |
Contributor
There was a problem hiding this comment.
maybe this could have a code snippit?
Contributor
Author
There was a problem hiding this comment.
yeah - we should revisit this section the next time we come in here. I think it could be better factored :)
| * http://creativecommons.org/publicdomain/zero/1.0/ */ | ||
|
|
||
| function toggleProjectSearch() { | ||
| function openProjectSearch(dbg) { |
| ); | ||
| } | ||
|
|
||
| function closeProjectSearch(dbg) { |
Contributor
|
some linting errors: |
3ad3fdd to
8c05407
Compare
Codecov Report
@@ Coverage Diff @@
## master #3661 +/- ##
=========================================
Coverage ? 54.69%
=========================================
Files ? 120
Lines ? 4821
Branches ? 1002
=========================================
Hits ? 2637
Misses ? 2184
Partials ? 0Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes