This repository was archived by the owner on Jan 11, 2023. It is now read-only.
minor project search improvements#3659
Merged
Merged
Conversation
jasonLaster
commented
Aug 14, 2017
|
|
||
| .project-text-search .file-result.focused { | ||
| background-color: #eeeeee; | ||
| background-color: var(--theme-selection-background); |
Contributor
Author
There was a problem hiding this comment.
these colors are a small step in the right direction
codehag
approved these changes
Aug 14, 2017
| const TextSearch = React.createFactory(_TextSearch); | ||
|
|
||
| import _Shortcuts from "./helpers/shortcuts"; | ||
| const Shortcuts = createFactory(_Shortcuts); |
Contributor
There was a problem hiding this comment.
Are we still using this pattern?
Contributor
Author
There was a problem hiding this comment.
I suppose we should JSX the stories too, but meh
| "align-self": "center" | ||
| width: "calc(100vw - 100px)", | ||
| height: "calc(100vh - 100px)", | ||
| margin: "auto", |
Contributor
There was a problem hiding this comment.
my gut instinct is to move styles that are not calculated to a class, but it was like this before so...
Contributor
Author
There was a problem hiding this comment.
yeah - it's a silly story, which is where I'm not sure
Contributor
|
we have a failing test: |
Contributor
Author
|
the test is fixed by the other PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #1108
Summary of Changes