Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Fix a couple mochi errors#3656

Merged
jasonLaster merged 2 commits into
firefox-devtools:masterfrom
jasonLaster:fix-fail
Aug 14, 2017
Merged

Fix a couple mochi errors#3656
jasonLaster merged 2 commits into
firefox-devtools:masterfrom
jasonLaster:fix-fail

Conversation

@jasonLaster
Copy link
Copy Markdown
Contributor

Summary of Changes

  • don't try to re-assign a const
  • show failed tests at the bottom
  • properly indent

screen shot 2017-08-14 at 2 44 34 pm

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 14, 2017

Codecov Report

Merging #3656 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3656      +/-   ##
==========================================
+ Coverage   54.69%   54.73%   +0.03%     
==========================================
  Files         120      120              
  Lines        4821     4825       +4     
  Branches     1002     1003       +1     
==========================================
+ Hits         2637     2641       +4     
  Misses       2184     2184
Impacted Files Coverage Δ
bin/mochi.js 73.18% <100%> (+1%) ⬆️
src/actions/ast.js 76.78% <0%> (-1.79%) ⬇️
src/components/shared/BracketArrow.js 40% <0%> (ø) ⬆️
src/utils/prefs.js 100% <0%> (ø) ⬆️
src/components/shared/Popover.js 5.71% <0%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7506411...dbecbf5. Read the comment docs.

Copy link
Copy Markdown
Contributor

@codehag codehag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small cleanup issue

Comment thread bin/mochi.js Outdated

if (data.mode == "done") {
return;
// console.log(line)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete this

@jasonLaster jasonLaster merged commit c9a9342 into firefox-devtools:master Aug 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants